feat: add new pattern "Request-Driven Web Service" to init AWS App Runner services #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: Efe Karakus <[email protected]> Date: 2021-05-14T01:46:10.000Z refactor: use the service name and id instead of the arn in svc status commit c885ed2e3dba91db0081720ac2472b5e14c8e030 Author: Efe Karakus <[email protected]> Date: 2021-05-13T20:57:30.000Z chore: remove tags from env var struct commit f67c76d47bad7f8ba89357a8fac65c50456f2418 Author: Efe Karakus <[email protected]> Date: 2021-05-13T20:54:28.000Z chore: limit marshaled fields commit 298430a9abcf1087be4e172380c80462aaf8c14d Author: Efe Karakus <[email protected]> Date: 2021-05-13T19:39:13.000Z chore: include image id in "svc status" and fix json tags cr: https://code.amazon.com/reviews/CR-50364135
* also updating the CFN healthcheck config to default to HTTP cr: https://code.amazon.com/reviews/CR-50546903
Previously, if the service was never created we would try to get its physical ID instead of returning an error. This would cause a segfault while dereferencing the pointer. cr: https://code.amazon.com/reviews/CR-50611564
Lou1415926
approved these changes
May 18, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…nner services (aws#2340) By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.