feat(cli): enable secret init #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
reviewed
May 17, 2021
efekarakus
reviewed
May 17, 2021
internal/pkg/cli/secret_init.go
Outdated
| "sort" | ||
| "strings" | ||
| goTemplate "text/template" |
There was a problem hiding this comment.
Suggested change
| goTemplate "text/template" | |
| txttemplate "text/template" |
https://rakyll.org/style-packages/#renames-should-follow-the-same-rules
| tmpl, _ := goTemplate.New("secretInitOutput").Parse(templateRaw) | ||
|
|
||
| log.Infoln("You can refer to these secrets from your manifest file by editing the `secrets` section.") | ||
| return tmpl.Execute(os.Stdout, secretInitOutput{ |
internal/pkg/cli/secret_init.go
Outdated
Comment on lines
485
to
491
| /code $ copilot secret init | ||
| Create a secret named db-password. | ||
| You will be prompted for the values you want for db-password in each existing environments. | ||
| /code $ copilot secret init --name db-password | ||
| Create a secret named db-password with values you want in each existing environments. | ||
| You will be prompted for the values you want for db-password in each existing environments. | ||
| /code $ copilot secret init --name db-password |
There was a problem hiding this comment.
Is this repeated twice?
There was a problem hiding this comment.
Addressed! I also addressed your feedback from last round (sorry I missed your comment somehow), shortening the example description language so that they are more terse. However I removed the one with --values flag since we want to encourage the user to use guided/input file so that the values are not visible in shell history.
efekarakus
approved these changes
May 18, 2021
iamhopaul123
approved these changes
May 18, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
Resolves aws#1920 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1920
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.