fix: create dedicated kms for Aurora addon #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kohidave
reviewed
Apr 22, 2021
templates/addons/aurora/cf.yml
Outdated
| Principal: | ||
| AWS: !Sub 'arn:aws:iam::${AWS::AccountId}:root' | ||
| Action: 'kms:*' | ||
| Resource: '*' |
There was a problem hiding this comment.
Can we limit these resources to just the Aurora DB?
There was a problem hiding this comment.
This statement is to prevent the key from being unmanageable in the future (doc). KMS guards against this sort of unmanageable situation and the resource will fail to create.
efekarakus
reviewed
Apr 22, 2021
templates/addons/aurora/cf.yml
Outdated
| @@ -31,6 +31,34 @@ Mappings: | |||
| {{end -}} | |||
| {{end}} | |||
| Resources: | |||
| {{logicalIDSafe .ClusterName}}AuroraKMSCMK: | |||
| Type: 'AWS::KMS::Key' | |||
| DeletionPolicy: Retain | |||
There was a problem hiding this comment.
Can we remove this deletion policy? 🙏
bvtujo
reviewed
Apr 22, 2021
templates/addons/aurora/cf.yml
Outdated
| Resource: '*' | ||
| Condition: | ||
| StringEquals: | ||
| 'kms:CallerAccount': !Ref 'AWS::AccountId' |
…s always encrpyted and default kms is used
iamhopaul123
added
do-not-merge
efekarakus
approved these changes
Apr 23, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
Previously the Aurora addons use the default KMS key for app by importing the exported KMS resource. However, it's not able to`ImportValue` if the service uses a different account. This PR fixes this issue by creating a dedicated KMS resource for each Aurora addon. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Aurora addons use the default KMS key for app by importing the exported KMS resource. However, it's not able to
ImportValueif the service uses a different account. This PR fixes this issue by creating a dedicated KMS resource for each Aurora addon.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.