-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cicd): add conditional field in pipeline manifest for connection_name #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-CSC:
CSC:
|
bvtujo
reviewed
Mar 17, 2021
…li-v2 into custom-connections
efekarakus
reviewed
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just some documentation updates 🙏
bvtujo
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
efekarakus
approved these changes
Mar 22, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…_name (aws#2073) These changes add a commented-out optional field in the pipeline manifest for `connection_name` when the source provider is GitHub or Bitbucket. Manually tested with non-CSC, Bb, GH, CSC w/ existing connection, CSC w/o existing connection. Updated docs accordingly. Related aws#2042, Resolves aws#2012, Resolves aws#1247, Related aws#1339. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a commented-out optional field in the pipeline manifest for
connection_name
when the source provider is GitHub or Bitbucket.Manually tested with non-CSC, Bb, GH, CSC w/ existing connection, CSC w/o existing connection.
Updated docs accordingly.
Related #2042, Resolves #2012, Resolves #1247, Related #1339.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.