Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cicd): add conditional field in pipeline manifest for connection_name #2073

Merged
merged 7 commits into from
Mar 22, 2021

Conversation

huanjani
Copy link
Contributor

@huanjani huanjani commented Mar 17, 2021

These changes add a commented-out optional field in the pipeline manifest for connection_name when the source provider is GitHub or Bitbucket.
Manually tested with non-CSC, Bb, GH, CSC w/ existing connection, CSC w/o existing connection.

Updated docs accordingly.

Related #2042, Resolves #2012, Resolves #1247, Related #1339.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@huanjani huanjani requested a review from a team as a code owner March 17, 2021 18:27
@huanjani huanjani requested a review from Lou1415926 March 17, 2021 18:27
@efekarakus efekarakus changed the title build(cicd): add conditional field in pipeline manifest for connection_name feat(cicd): add conditional field in pipeline manifest for connection_name Mar 17, 2021
@huanjani
Copy link
Contributor Author

Non-CSC:

  # Additional properties that further specifies the exact location
  # the artifacts should be sourced from. For example, the GitHub provider
  # has the following properties: repository, branch.
  properties:
    branch: master
    repository: https://us-west-2.console.aws.amazon.com/codesuite/codecommit/repositories/aws-sample/browse

# The deployment section defines the order the pipeline will deploy
# to your environments.

CSC:

 # Additional properties that further specifies the exact location
  # the artifacts should be sourced from. For example, the GitHub provider
  # has the following properties: repository, branch.
  properties:
    branch: master
    repository: https://[email protected]/huanjani/aws-copilot-sample-service
    # Optional: specify the name of an existing CodeStar Connections connection.
    # connection_name:

# The deployment section defines the order the pipeline will deploy
# to your environments.

Copy link
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just some documentation updates 🙏

Copy link
Contributor

@bvtujo bvtujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mergify mergify bot merged commit fd5a060 into aws:mainline Mar 22, 2021
@huanjani huanjani deleted the custom-connections branch March 22, 2021 18:55
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
…_name (aws#2073)

These changes add a commented-out optional field in the pipeline manifest for `connection_name` when the source provider is GitHub or Bitbucket.
Manually tested with non-CSC, Bb, GH, CSC w/ existing connection, CSC w/o existing connection.

Updated docs accordingly.

Related aws#2042, Resolves aws#2012, Resolves aws#1247, Related aws#1339.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants