chore: ignore INACTIVE cluster in DefaultCluster #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we delete ECS cluster, AWS return it as INACTIVE cluster. ``` INACTIVE The cluster has been deleted. Clusters with an INACTIVE status may remain discoverable in your account for a period of time. However, this behavior is subject to change in the future, so you should not rely on INACTIVE clusters persisting. ``` https://docs.aws.amazon.com/AmazonECS/latest/developerguide/clusters.html We can't run task on INACTIVE cluster so we should ignore it.
Lou1415926
reviewed
Mar 11, 2021
ota42y
changed the title
|
I have completed the fix! |
efekarakus
changed the title
Lou1415926
approved these changes
Mar 12, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
When we delete ECS cluster, AWS return it as INACTIVE cluster. ``` INACTIVE The cluster has been deleted. Clusters with an INACTIVE status may remain discoverable in your account for a period of time. However, this behavior is subject to change in the future, so you should not rely on INACTIVE clusters persisting. ``` https://docs.aws.amazon.com/AmazonECS/latest/developerguide/clusters.html We can't run task on INACTIVE cluster so we should ignore it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we delete ECS cluster, AWS return it as INACTIVE cluster.
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/clusters.html
We can't run task on INACTIVE cluster so we should ignore it.