chore: log cmd to create default cluster on task run error #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
reviewed
Mar 11, 2021
|
I have completed the fix! |
efekarakus
approved these changes
Mar 11, 2021
| @@ -16,8 +16,7 @@ Generally, the steps involved in task run are: | |||
| !!!info | |||
| 1. Tasks with the same group name share the same set of resources, including the CloudFormation stack, ECR repository, CloudWatch log group and task definition. | |||
| 2. If the tasks are deployed to a Copilot environment (i.e. by specifying `--env`), only public subnets that are created by that environment will be used. | |||
| 3. The `--env` flag only works with environments created with v0.3.0 of Copilot or later. Customers using environments created with v0.2.0 or earlier can update their environment manager role with [this](https://github.com/aws/copilot-cli/blob/mainline/templates/environment/cf/environment-manager-role.yml) policy. | |||
| 4. If you are using the `--default` flag and get an error saying there's no default cluster, run `aws ecs create-cluster` and then re-run the Copilot command. | |||
| 3. If you are using the `--default` flag and get an error saying there's no default cluster, run `aws ecs create-cluster` and then re-run the Copilot command. | |||
There was a problem hiding this comment.
This is also no longer needed :) since we moved it to the code
efekarakus
changed the title
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
When we don't set `--env` flags, [Copilot run task on default cluster](https://github.com/aws/copilot-cli/blob/mainline/internal/pkg/cli/task_run.go#L197). In the old description, it is difficult to understand what happens if we don't set `--default` flag. Copilot allows to deploy the service to another region(environment) without changing profile's region, but task run without `--env` use default region only (perhaps) so I added description about region. I think it is better to add `--region` option in `run task` command but there is a workaround so I can't say it should be done 🤔 Therefore, I added only the explanation first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we don't set
--envflags, Copilot run task on default cluster.In the old description, it is difficult to understand what happens if we don't set
--defaultflag.Copilot allows to deploy the service to another region(environment) without changing profile's region, but task run without
--envuse default region only (perhaps) so I added description about region.I think it is better to add
--regionoption inrun taskcommand but there is a workaround so I can't say it should be done 🤔Therefore, I added only the explanation first.