fix(task): use only env security group for task run #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
approved these changes
Jan 27, 2021
internal/pkg/task/env_runner_test.go
Outdated
| @@ -30,6 +30,10 @@ func TestEnvRunner_Run(t *testing.T) { | |||
| Values: []string{inApp}, | |||
| }, | |||
| } | |||
| filtersForSecurityGroup := append(filtersForSubnetID, ec2.Filter{ | |||
| Name: fmt.Sprintf(ec2.TagFilterName, envSecurityGroupCFNLogicalIDTagKey), | |||
There was a problem hiding this comment.
nit: Can we use the strings directly? like "tag:aws:cloudformation:logical-id" to make sure that the function under test does the translation properly
huanjani
added
the
do-not-merge
huanjani
approved these changes
Jan 27, 2021
iamhopaul123
removed
the
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1882.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.