chore(templates): output for DiscoveryServiceARN #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
changed the title
efekarakus
changed the title
efekarakus
reviewed
Jan 22, 2021
There was a problem hiding this comment.
Awesome, thank you so much! 😍
Can we include the same output to https://github.com/aws/copilot-cli/blob/mainline/templates/workloads/services/lb-web/cf.yml so that both service types can benefit this change?
|
ps: you might need to add at least one commit with the conventional commit format. For example: |
…d backend service
efekarakus
approved these changes
Jan 22, 2021
iamhopaul123
approved these changes
Jan 22, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
Added output section in templates/workloads/services/backend/cf.yml to export the DiscoverService.ARN so that can be used by other CF stack. Resolves aws#1864 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added output section in templates/workloads/services/backend/cf.yml to export the DiscoverService.ARN so that can be used by other CF stack.
Resolves #1864
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.