Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manifest): add allow source IP field #1643

Merged
merged 11 commits into from
Nov 7, 2020
Merged

Conversation

huanjani
Copy link
Contributor

@huanjani huanjani commented Nov 6, 2020

This gives users the option to limit access to their load balanced web services to certain IP address ranges.

Resolves #1234; partially addresses #1453.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@huanjani huanjani requested a review from a team as a code owner November 6, 2020 17:16
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just one small nit :shipit:

@efekarakus efekarakus changed the title chore(manifest): add allow source IP field feat(manifest): add allow source IP field Nov 6, 2020
@efekarakus efekarakus added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Nov 6, 2020
Copy link
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double check, we're not writing anything in the manifest to showcase this field right?

I'm fine with that I just wanted to make sure.

@huanjani
Copy link
Contributor Author

huanjani commented Nov 6, 2020

Just to double check, we're not writing anything in the manifest to showcase this field right?

I'm fine with that I just wanted to make sure.

correct!

@huanjani huanjani removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Nov 7, 2020
@mergify mergify bot merged commit d59e58a into aws:mainline Nov 7, 2020
@huanjani huanjani deleted the allow-list branch November 7, 2020 00:43
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
This gives users the option to limit access to their load balanced web services to certain IP address ranges.

Resolves aws#1234; partially addresses aws#1453.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IP Allow List to LoadBalancedWeb Service Pattern
3 participants