feat(pipeline): add pipeline ls cmd #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoManyHs
force-pushed
the
pipeline-list
branch
3 times, most recently
from
bf738ea to
0628075
Compare
bvtujo
reviewed
Oct 21, 2020
| // Execute writes the pipelines. | ||
| func (o *listPipelineOpts) Execute() error { | ||
| var out string | ||
| if o.shouldOutputJSON { |
There was a problem hiding this comment.
Does this fit into the paradigm we started with the job ls command? Could we move this logic to the list package? https://github.com/aws/copilot-cli/blob/mainline/internal/pkg/list/list.go It looks like this uses a lot of the same APIs and flags as the other list commands so it might go nicely.
There was a problem hiding this comment.
I was modeling this off of the env list command, so wasn't aware of ongoing restructuring.
bvtujo
approved these changes
Oct 21, 2020
efekarakus
added
do-not-merge
SoManyHs
force-pushed
the
pipeline-list
branch
from
30becd8 to
35823c5
Compare
iamhopaul123
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1499
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.