-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): allow backend service to not expose any port #1478
Conversation
Manual TestManifest# The manifest for the "test" service.
# Read the full specification for the "Backend Service" type at:
# https://github.com/aws/copilot-cli/wiki/Manifests#backend-svc
# Your service name will be used in naming your resources like log groups, ECS services, etc.
name: test
# Your service does not allow any traffic.
type: Backend Service
image:
# Docker build arguments. You can specify additional overrides here. Supported: dockerfile, context, args
build: Dockerfile
# Number of CPU units for the task.
cpu: 256
# Amount of memory in MiB used by the task.
memory: 512
# Number of tasks that should be running in your service.
count: 1 After deployment
svc show
|
dd880cc
to
8b99efe
Compare
Can you ensure that you can add a port after the service is created w/o a port and that service discovery works, please? |
It works! I tested on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As far as I'm concerned this also closes #1246 😄 |
@hnrc yay! how do you do the "SNS <-> SQS <-> Service" integration today? |
@efekarakus SNS and SQS is managed by Cloudformation and Service is just a dumb infinite loop polling SQS. |
b5d8de4
to
630d4eb
Compare
fix #1435.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.