fix(cli): autoscaling range default value #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mRoca
force-pushed
the
fix/range-default-value
branch
from
8704f83 to
d818330
Compare
kohidave
requested review from
efekarakus and
iamhopaul123
and removed request for
kohidave
iamhopaul123
approved these changes
Oct 6, 2020
Thank you so much for finding and fixing this bug!
huanjani
approved these changes
Oct 6, 2020
efekarakus
reviewed
Oct 6, 2020
|
OK I see it now :) yay thank you! |
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
<!-- Provide summary of changes -->
When using the following manifest file and deploying on `production` env, the `range` value is set to an empty string :
```yaml
name: foobar
type: Load Balanced Web Service
image:
build: Dockerfile
port: 80
count:
range: 2-6
cpu_percentage: 70
memory_percentage: 80
environments:
production:
variables:
MODE: production
```
After running the command:
```
# copilot svc package -n foobar -e production --output-dir /tmp/out
✘ generate stack template: convert the Auto Scaling configuration for service adminapi: invalid range value . Should be in format of ${min}-${max}
```
This bug comes from this code:
```go
// internal/pkg/manifest/lb_web_svc.go
func (s LoadBalancedWebService) ApplyEnv(envName string) (*LoadBalancedWebService, error) {
// ...
err := mergo.Merge(&s, LoadBalancedWebService{
LoadBalancedWebServiceConfig: *overrideConfig,
}, mergo.WithOverride, mergo.WithOverwriteWithEmptyValue)
```
As the `mergo.WithOverwriteWithEmptyValue` option is used, the `Autoscaling.Range` value is overrided by the default one, which is an empty string.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the following manifest file and deploying on
productionenv, therangevalue is set to an empty string :After running the command:
This bug comes from this code:
As the
mergo.WithOverwriteWithEmptyValueoption is used, theAutoscaling.Rangevalue is overrided by the default one, which is an empty string.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.