fix(task): quoting and command argument parsing #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvtujo
reviewed
Oct 5, 2020
| @@ -18,7 +18,7 @@ Parameters: | |||
| ExecutionRole: | |||
| Type: String | |||
| Command: | |||
| Type: String | |||
| Type: CommaDelimitedList | |||
There was a problem hiding this comment.
Does this require a documentation change? Like, is it backwards compatible if people just want to use double quotes?
There was a problem hiding this comment.
it's backwards compatible. it's not a new change but just a bug fix i think.
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2021
In #1998, the way that the strings are split into string slice may cause bugs when passing the values to cfn template. This PR implements a similar fix as #1467. Fixes #1998 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
In aws#1998, the way that the strings are split into string slice may cause bugs when passing the values to cfn template. This PR implements a similar fix as aws#1467. Fixes aws#1998 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1466
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.