feat(templates): enable autoscaling for simple target track policies #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual TestBelow shows a manifest example that enables Auto Scaling and apply multiple target tracking policies to the auto scaling. And after doing
|
iamhopaul123
force-pushed
the
autoscaling/CFN
branch
from
5dc6821 to
03a79ec
Compare
iamhopaul123
changed the title
iamhopaul123
added
the
type/breaking-change
iamhopaul123
force-pushed
the
autoscaling/CFN
branch
from
03a79ec to
8d681b5
Compare
iamhopaul123
changed the title
iamhopaul123
removed
the
type/breaking-change
efekarakus
approved these changes
Sep 4, 2020
iamhopaul123
force-pushed
the
autoscaling/CFN
branch
from
19fffc3 to
40c6bb5
Compare
huanjani
approved these changes
Sep 4, 2020
mergify bot
pushed a commit
that referenced
this pull request
Sep 16, 2020
<!-- Provide summary of changes --> Since we now enable auto scaling in #1355. This feature enable `svc status` to show any alarms created by auto scaling. After this PR `svc status` should be able to show alarms created by auto scaling or alarms with copilot tags. <!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…ws#1355) <!-- Provide summary of changes --> Part of aws#1349. Enable Auto Scaling for simple target track policies by updating CFN template. Will add e2e test in a separate PR after this one. Also will add a custom resource to set `desiredCount` smartly so that when users update their ECS service there won't be a sudden increment/decrement to their task num. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
<!-- Provide summary of changes --> Since we now enable auto scaling in aws#1355. This feature enable `svc status` to show any alarms created by auto scaling. After this PR `svc status` should be able to show alarms created by auto scaling or alarms with copilot tags. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1349. Enable Auto Scaling for simple target track policies by updating CFN template. Will add e2e test in a separate PR after this one. Also will add a custom resource to set
desiredCountsmartly so that when users update their ECS service there won't be a sudden increment/decrement to their task num.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.