fix(logs) logs should not color words with the ERR substring #1350
Conversation
corykitchens
force-pushed
the
logs-colored-codes
branch
from
73563de to
564e54d
Compare
There was a problem hiding this comment.
Thanks for contributing! I believe this can fix the issue for now but in the long run we might still have similar problems if there's any keyword containing "fatal" or something else that will be colored unexpectedly. Would you mind taking a different route like preventing any keyword with substring fatalCodes to be colored?
| words := strings.Split(message, " ") | ||
| for i, word := range words { | ||
| if word == code { | ||
| words[i] = givenColor.Sprint(word) |
There was a problem hiding this comment.
Btw, looks like this ERR: .... error message could not be shown with ERR to be in red right?
There was a problem hiding this comment.
I wonder if we can make use of regex to do this matching stuff https://play.golang.org/p/uPTVbBXzXFz
There was a problem hiding this comment.
Awesome thanks for all the feedback @iamhopaul123 and including a snippet of the regex!
…g codes in Event messages
Addresses aws#1312 Removes the element `ERR` from the `fatalCodes` slice This ensures that any Event struct containing the substring "ERR" will no longer be color-coded. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Addresses #1312
Removes the element
ERRfrom thefatalCodessliceThis ensures that any Event struct containing the substring "ERR" will no longer be color-coded.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.