Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stack): render test commands with quotes in pipeline cfn template #1327

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

efekarakus
Copy link
Contributor

@efekarakus efekarakus commented Aug 25, 2020

By using the literal block scalar syntax for the buildspec, we
remove the double quotes from our inlined buildspec which means that
users can now use them in their commands. This has also the additional
benefit of increasing readability.

Fixes #1279

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

By using the literal block scalar syntax for the buildspec, we
remove the double quotes from our inlined buildspec which means that
users can now use them in their commands. This has also the additional
benefit of increasing visibility.

Fixes aws#1279
@efekarakus efekarakus requested review from huanjani and a team August 25, 2020 22:35
@amazon-ecs-cli-v2-pr-manager amazon-ecs-cli-v2-pr-manager removed the request for review from a team August 25, 2020 22:35
@efekarakus efekarakus requested a review from a team August 25, 2020 22:36
Copy link
Contributor

@kohidave kohidave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hype.

@mergify mergify bot merged commit b526544 into aws:mainline Aug 26, 2020
@efekarakus efekarakus deleted the issues/1279-buildspec-fix branch January 6, 2021 17:53
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
…aws#1327)

By using the literal block scalar syntax for the buildspec, we
remove the double quotes from our inlined buildspec which means that
users can now use them in their commands. This has also the additional
benefit of increasing readability.

Fixes aws#1279

_By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Test commands in pipeline.yml are not properly escaped
3 participants