fix(manifest): escape env var values while rendering CFN template #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
changed the title
efekarakus
changed the title
efekarakus
added
the
do-not-merge
|
Added the "do-not-merge" label while running e2e tests. |
|
I kind of miss our golden file integ tests. They'd compare the packaged cf template to the expected cf template. That'd help with this class of error. |
kohidave
approved these changes
Aug 25, 2020
huanjani
approved these changes
Aug 25, 2020
I'll use |
efekarakus
added
do-not-merge
efekarakus
removed
the
do-not-merge
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…s#1322) Use the %q verb (a double-quoted string safely escaped with Go syntax) when writing env var values. This ensures that values like `"{}"` or `on` are written as strings instead of a mapping or boolean object. Fixes aws#1120, fixes aws#1292 _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the %q verb (a double-quoted string safely escaped with Go syntax)
when writing env var values. This ensures that values like
"{}"oronare written as strings instead of a mapping or boolean object.Fixes #1120, fixes #1292
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.