fix: add UntagResource permission for KMS key #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be an issue with the current KMS CF resource that is causing superfluous tag/untag calls. This new permission fixes that issue. A customer encountered this issue (aws#1199) when using resource tags, so I've also updated the e2e tests to include setting resource tags. In the future, this permission will be useful if we want to support updating tags at the app level (removing a tag, for example) so it's not entierly a hack :)
efekarakus
approved these changes
Jul 29, 2020
|
|
||
| if len(opts.Tags) > 0 { | ||
| commands = append(commands, "--resource-tags") | ||
| tags := []string{} |
There was a problem hiding this comment.
you're killing me david
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue with the current KMS CF resource
that is causing superfluous tag/untag calls. This new permission
fixes that issue.
A customer encountered this issue (#1199) when using resource tags,
so I've also updated the e2e tests to include setting resource tags.
In the future, this permission will be useful if we want to support
updating tags at the app level (removing a tag, for example) so it's
not entierly a hack :)
Fixes #1199
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.