feat(cli): enable "env show" command #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
requested review from
a team and
kohidave
and removed request for
a team
iamhopaul123
approved these changes
Jul 17, 2020
bvtujo
approved these changes
Jul 17, 2020
| @@ -151,7 +151,6 @@ func BuildEnvShowCmd() *cobra.Command { | |||
| GlobalOpts: NewGlobalOpts(), | |||
| } | |||
| cmd := &cobra.Command{ | |||
| Hidden: true, //TODO remove when ready for production! | |||
There was a problem hiding this comment.
Are there any other templates where this command needs to be added, or were those issues specific to storage requiring us to enable a new command group?
There was a problem hiding this comment.
yup that was unique "storage init" if the group already exists nothing needs to be done
Louise15926
pushed a commit
to Louise15926/amazon-ecs-cli-v2
that referenced
this pull request
Jul 20, 2020
_By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.