Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): app init not check domain name if flag not set #1156

Merged
merged 2 commits into from
Jul 16, 2020
Merged

fix(cli): app init not check domain name if flag not set #1156

merged 2 commits into from
Jul 16, 2020

Conversation

iamhopaul123
Copy link
Contributor

fixes #1148

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@iamhopaul123 iamhopaul123 requested a review from efekarakus July 16, 2020 17:13
@iamhopaul123 iamhopaul123 requested a review from a team as a code owner July 16, 2020 17:13
bvtujo
bvtujo approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@bvtujo bvtujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching this!

@mergify mergify bot merged commit d244f98 into aws:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efekarakus efekarakus efekarakus approved these changes

@bvtujo bvtujo bvtujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting up an app with DNS breaks copilot init
3 participants
@iamhopaul123 @efekarakus @bvtujo