Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display correct GitHub URL flag name for 'copilot pipeline init' command #1114

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

carlosafonso
Copy link
Contributor

When calling copilot pipeline init, if Copilot cannot parse the GitHub repo from the provided URL an error message is thrown. There is a reference to a CLI flag, --url, which seems to be incorrect. The correct flag is --github-url. This PR changes it.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@carlosafonso carlosafonso requested a review from a team as a code owner July 10, 2020 09:27
@carlosafonso carlosafonso requested a review from kohidave July 10, 2020 09:27
@carlosafonso carlosafonso changed the title Fix GitHub repo URL flag name for 'copilot pipeline init' command fix: Display correct GitHub URL flag name for 'copilot pipeline init' command Jul 10, 2020
@seongm-1
Copy link
Contributor

seongm-1 commented Jul 10, 2020

Hi! Thanks for the finding this bug and fix!

Copy link
Contributor

@kohidave kohidave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!!!!! 🎉🎉👩‍✈️

@mergify mergify bot merged commit be7516c into aws:master Jul 10, 2020
Louise15926 pushed a commit to Louise15926/amazon-ecs-cli-v2 that referenced this pull request Jul 13, 2020
… command (aws#1114)

When calling `copilot pipeline init`, if Copilot cannot parse the GitHub repo from the provided URL an error message is thrown. There is a reference to a CLI flag, `--url`, which seems to be incorrect. The correct flag is `--github-url`. This PR changes it.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants