-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment Variable and Secret for Sidecar container #1119
Comments
Hello @FarmaanElahi, This is a very useful feedback! I think we should support injecting env variables and secrets for sidecar. Thanks for bringing it up! |
Could this also be used for adding args to the sidecar? environment variables would probably be enough to write my own docker-entrypoint.sh and wrap the command but it would be nice to get native support. I could also open a new issue for arg/cmd support if that makes sense. |
@iamhopaul123 any timeline for this? |
@iamhopaul123 Appreciate this being prioritized! A few unsolicited thoughts:
|
Hello @bdevore17, so sorry for the late reply. We probably won't be able to do this feature very soon but I'll try to get to it as soon as possible and keep you posted!
Really appreciate this input. It is very helpful to us! |
This feature was released just now in v1.1.0: https://github.com/aws/copilot-cli/releases/tag/v1.1.0 |
Currently adding env variable and secrets for the works for the main container.
There might be some scenario where env variable and secrets for sidecar might be required which is currently missing
The text was updated successfully, but these errors were encountered: