Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Variable and Secret for Sidecar container #1119

Closed
FarmaanElahi opened this issue Jul 10, 2020 · 6 comments · Fixed by #1725
Closed

Environment Variable and Secret for Sidecar container #1119

FarmaanElahi opened this issue Jul 10, 2020 · 6 comments · Fixed by #1725
Assignees
Labels
area/sidecar Issues about sidecar containers. size/M We should be able to deliver roughly 1 medium issue in a sprint. type/enhancement Issues that are improvements for existing features. type/request Issues that are created by customers.

Comments

@FarmaanElahi
Copy link

Currently adding env variable and secrets for the works for the main container.

There might be some scenario where env variable and secrets for sidecar might be required which is currently missing

@efekarakus efekarakus added type/enhancement Issues that are improvements for existing features. type/request Issues that are created by customers. area/sidecar Issues about sidecar containers. labels Jul 10, 2020
@iamhopaul123
Copy link
Contributor

Hello @FarmaanElahi,

This is a very useful feedback! I think we should support injecting env variables and secrets for sidecar. Thanks for bringing it up!

@rothgar
Copy link

rothgar commented Sep 21, 2020

Could this also be used for adding args to the sidecar? environment variables would probably be enough to write my own docker-entrypoint.sh and wrap the command but it would be nice to get native support.

I could also open a new issue for arg/cmd support if that makes sense.

@bdevore17
Copy link

@iamhopaul123 any timeline for this?

@bdevore17
Copy link

bdevore17 commented Nov 4, 2020

@iamhopaul123 Appreciate this being prioritized! A few unsolicited thoughts:

  • both explicit and implicit sidecars (like firelens) should be supported
  • this feature is only truly useful if we can parameterize the values based on copilot environment

@iamhopaul123
Copy link
Contributor

Hello @bdevore17, so sorry for the late reply. We probably won't be able to do this feature very soon but I'll try to get to it as soon as possible and keep you posted!

this feature is only truly useful if we can parameterize the values based on copilot environment

Really appreciate this input. It is very helpful to us!

@efekarakus efekarakus added the size/M We should be able to deliver roughly 1 medium issue in a sprint. label Nov 16, 2020
@iamhopaul123 iamhopaul123 self-assigned this Nov 24, 2020
@mergify mergify bot closed this as completed in #1725 Nov 30, 2020
mergify bot pushed a commit that referenced this issue Nov 30, 2020
<!-- Provide summary of changes -->
fixes #1119
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@efekarakus
Copy link
Contributor

This feature was released just now in v1.1.0: https://github.com/aws/copilot-cli/releases/tag/v1.1.0

thrau pushed a commit to localstack/copilot-cli-local that referenced this issue Dec 9, 2022
<!-- Provide summary of changes -->
fixes aws#1119
<!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sidecar Issues about sidecar containers. size/M We should be able to deliver roughly 1 medium issue in a sprint. type/enhancement Issues that are improvements for existing features. type/request Issues that are created by customers.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants