fix: remove project prefix when creating pipeline stack name (#854)

This was creating inconsistencies between the name of the stack in the pipeline.yml file and the one being deployed
aws · Apr 20, 2020 · 62e5515 · 62e5515
1 parent aa0b7b1
commit 62e5515
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/internal/pkg/deploy/cloudformation/stack/pipeline.go b/internal/pkg/deploy/cloudformation/stack/pipeline.go
@@ -25,7 +25,7 @@ func NewPipelineStackConfig(in *deploy.CreatePipelineInput) *pipelineStackConfig
 }
 
 func (p *pipelineStackConfig) StackName() string {
-	return p.ProjectName + "-" + p.Name
+	return p.Name
 }
 
 func (p *pipelineStackConfig) Template() (string, error) {

diff --git a/internal/pkg/deploy/cloudformation/stack/pipeline_test.go b/internal/pkg/deploy/cloudformation/stack/pipeline_test.go
@@ -58,8 +58,7 @@ func TestPipelineStackName(t *testing.T) {
 		mockCreatePipelineInput(),
 	)
 
-	require.Equal(t, projectName+"-"+pipelineName,
-		pipeline.StackName(), "unexpected StackName")
+	require.Equal(t, pipelineName, pipeline.StackName(), "unexpected StackName")
 }
 
 func TestPipelineStackConfig_Template(t *testing.T) {