Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default sampling_req in LocalSampler to None #89

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

eric-luminal
Copy link
Contributor

AWSXRayRecorder.begin_segment was not passing sampling_req causing the following stacktrace when invoked inside of a lambda with all default sampling configurations

{
  "errorMessage": "should_trace() missing 1 required positional argument: 'sampling_req'",
  "errorType": "TypeError",
  "stackTrace": [
    [
      "/var/task/app.py",
      60,
      "lambda_handler",
      "metadata={'api': {'event': event}}):"
    ],
    [
      "/var/task/app.py",
      16,
      "segment",
      "seg = xray_recorder.begin_segment(name)"
    ],
    [
      "/var/task/aws_xray_sdk/core/recorder.py",
      208,
      "begin_segment",
      "decision = self._sampler.should_trace()"
    ]
  ]
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haotianw465 haotianw465 merged commit 17dc875 into aws:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants