Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sample app dependencies incompatibility with xray sdk #382

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Fix sample app dependencies incompatibility with xray sdk #382

merged 1 commit into from
Mar 28, 2023

Conversation

wangzlei
Copy link
Contributor

@wangzlei wangzlei commented Mar 28, 2023 •
edited
Loading

Issue #, if available:
https://github.com/aws/aws-xray-sdk-python/actions/runs/4196198140

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wangzlei wangzlei requested a review from a team as a code owner March 28, 2023 17:56
@wangzlei wangzlei requested a review from srprash March 28, 2023 17:57
srprash
srprash approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangzlei wangzlei merged commit 82cdf8d into aws:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srprash srprash srprash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangzlei @srprash