Modified context missing strategy default to log error #372
Conversation
| xray_recorder = get_new_stubbed_recorder() | ||
| xray_recorder.configure(sampling=False, context_missing='RUNTIME_ERROR') | ||
|
|
||
| with pytest.raises(SegmentNotFoundException): |
There was a problem hiding this comment.
I'm not too familiar with Python. If there is not an exception throw, as expected, then will this test fail?
Or is the 'with' keyword more of a 'if this exception is thrown then do X'. And this test will just pass.
There was a problem hiding this comment.
It will! This is what happens when you modify the context_missing parameter to be LOG_ERROR in this test:
Failed: DID NOT RAISE <class 'aws_xray_sdk.core.exceptions.exceptions.SegmentNotFoundException'>
There was a problem hiding this comment.
Adding to Carol's comment above, this is a common way in pytest to assert that a certain exception is thrown in a unit test. Documentation for reference: https://docs.pytest.org/en/7.1.x/how-to/assert.html#assertions-about-expected-exceptions
Issue #, if available: N/A
Description of changes: To maintain consistency across SDKs and to prevent malformed trace headers from breaking services, this PR sets the default context missing strategy to
'LOG_ERROR'instead of'RUNTIME_ERROR'.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.