-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument httpx >= 0.20 #357
Conversation
fbb6dd2
to
e41d623
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me, except for few small callouts. Thanks for contributing this new instrumentation! :)
The test failures are unrelated. flask-sqlalchemy 3.0 was released with many breaking changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Switch to upstream patches * Switch sources to git repo for easier backporting * Cleanup comments * Add httpx for [1] * Disable broken tests [1] aws/aws-xray-sdk-python#357 git-svn-id: file:///srv/repos/svn-community/svn@1346564 9fca08f4-af9d-4005-b8df-a31f2cc04f65
* Switch to upstream patches * Switch sources to git repo for easier backporting * Cleanup comments * Add httpx for [1] * Disable broken tests [1] aws/aws-xray-sdk-python#357 git-svn-id: file:///srv/repos/svn-community/svn@1346564 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Issue #, if available: #248
Description of changes: Instrument httpx >= 0.20
The tests are the same as for requests. That should be a good fit as httpx “aims to be broadly compatible with the requests API”.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.