Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument httpx >= 0.20 #357

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Instrument httpx >= 0.20 #357

merged 4 commits into from
Oct 17, 2022

Conversation

michael-k
Copy link
Contributor

Issue #, if available: #248

Description of changes: Instrument httpx >= 0.20

The tests are the same as for requests. That should be a good fit as httpx “aims to be broadly compatible with the requests API”.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michael-k michael-k requested a review from a team as a code owner September 27, 2022 19:42
@michael-k michael-k force-pushed the httpx branch 2 times, most recently from fbb6dd2 to e41d623 Compare September 27, 2022 19:58
Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me, except for few small callouts. Thanks for contributing this new instrumentation! :)

aws_xray_sdk/ext/httpx/patch.py Outdated Show resolved Hide resolved
aws_xray_sdk/ext/httpx/patch.py Outdated Show resolved Hide resolved
@michael-k
Copy link
Contributor Author

The test failures are unrelated. flask-sqlalchemy 3.0 was released with many breaking changes.

Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srprash srprash merged commit 80dbd1d into aws:master Oct 17, 2022
@michael-k michael-k deleted the httpx branch October 17, 2022 21:21
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Nov 11, 2022
* Switch to upstream patches
* Switch sources to git repo for easier backporting
* Cleanup comments
* Add httpx for [1]
* Disable broken tests

[1] aws/aws-xray-sdk-python#357

git-svn-id: file:///srv/repos/svn-community/svn@1346564 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Nov 11, 2022
* Switch to upstream patches
* Switch sources to git repo for easier backporting
* Cleanup comments
* Add httpx for [1]
* Disable broken tests

[1] aws/aws-xray-sdk-python#357


git-svn-id: file:///srv/repos/svn-community/svn@1346564 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants