Handling condition where Entity.cause is not a dict. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
===========================================
- Coverage 79.37% 44.42% -34.96%
===========================================
Files 82 82
Lines 3248 3253 +5
===========================================
- Hits 2578 1445 -1133
- Misses 670 1808 +1138
Continue to review full report at Codecov.
|
Hargrav3s
pushed a commit
to Gavant/aws-xray-sdk-python
that referenced
this pull request
Mar 22, 2022
* Handling condition where cause is not a dict. Exceptions should be appended not replaced. * Adding more test cases * Minor fixes to some tests * Some type checking in python2 may require to import unicode literals * Checking python version for type comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #154
Description of changes:
In a case of exception chaining where an unhandled exception is captured in a subsegment and then propagated to the parent segment/subsegment, the
causeproperty of this parent entity becomes astrfromdictto record the exception id from the child subsegment. Any further dictionary operation thiscausewill result in TypeError.Doing a type check on the Entity.cause when adding a new exception and resetting the cause to dict since we cannot recover the original cause dict once it has been updated to a string.
Also, making sure when adding multiple exceptions to an entity, they should be appended and not replaced.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.