Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Coverage to 4.5.4 #197

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Conversation

chanchiem
Copy link
Contributor

Coverage 5.0 had introduced a bug for us and is causing our tox tests to throw a
Segment Missing Exception upon starting coverage. Downgrading to 4.5.4 while we
investigate the root cause.

Issue #, if available:
#195

Description of changes:
Downgraded coverage to 4.5.4

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Coverage 5.0 had introduced a bug for us and is causing our tox tests to throw a
Segment Missing Exception upon starting coverage. Downgrading to 4.5.4 while we
investigate the root cause.
@chanchiem chanchiem changed the title Downgrade Coverage to 4.5.4 (#195) Downgrade Coverage to 4.5.4 Dec 17, 2019
@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #197 into master will increase coverage by 2.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   81.58%   83.84%   +2.25%     
==========================================
  Files          72       77       +5     
  Lines        2743     3003     +260     
==========================================
+ Hits         2238     2518     +280     
+ Misses        505      485      -20
Impacted Files Coverage Δ
aws_xray_sdk/core/models/trace_header.py 100% <0%> (ø) ⬆️
aws_xray_sdk/core/sampling/rule_cache.py 100% <0%> (ø) ⬆️
aws_xray_sdk/core/async_recorder.py 92% <0%> (ø)
aws_xray_sdk/ext/aiohttp/middleware.py 97.72% <0%> (ø)
aws_xray_sdk/ext/aiohttp/client.py 97.5% <0%> (ø)
aws_xray_sdk/ext/pymongo/patch.py 0% <0%> (ø)
aws_xray_sdk/ext/aiobotocore/patch.py 92.85% <0%> (ø)
aws_xray_sdk/core/models/subsegment.py 96.96% <0%> (+0.09%) ⬆️
aws_xray_sdk/core/daemon_config.py 97.95% <0%> (+0.18%) ⬆️
aws_xray_sdk/core/streaming/default_streaming.py 96.77% <0%> (+0.22%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a4d00...f67eb32. Read the comment docs.

@chanchiem chanchiem merged commit 4689220 into aws:master Dec 17, 2019
@chanchiem chanchiem deleted the coverage_downgrade branch December 17, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants