Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster Implementation of Wildcard Matching and added test file for wildcard matching #178

Merged
merged 4 commits into from
Oct 16, 2019
Merged

Conversation

bhautikpip
Copy link
Contributor

@bhautikpip bhautikpip commented Oct 9, 2019

Issue #, if available:

Description of changes:

  1. Faster Implementation of Wildcard matching
  2. Added test file for wildcard_match function

I have tested this change with the newly added test function.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #178 into master will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #178     +/-   ##
=========================================
+ Coverage    83.1%   83.51%   +0.4%     
=========================================
  Files          77       77             
  Lines        2918     2905     -13     
=========================================
+ Hits         2425     2426      +1     
+ Misses        493      479     -14
Impacted Files Coverage Δ
aws_xray_sdk/core/utils/search_pattern.py 100% <100%> (+10.86%) ⬆️
aws_xray_sdk/core/patcher.py 87.2% <0%> (+1.6%) ⬆️
aws_xray_sdk/ext/httplib/patch.py 75.78% <0%> (+3.15%) ⬆️
aws_xray_sdk/core/utils/compat.py 95.23% <0%> (+9.52%) ⬆️
aws_xray_sdk/core/sampling/local/reservoir.py 100% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 372efaa...d5d8743. Read the comment docs.

@chanchiem
Copy link
Contributor

It looks like code coverage decreased. Can we make sure all code paths are executed in your tests? Additionally, it would be nice if we could get a high level description of the algorithm in the comments for readability purposes.

And can we also confirm that these tests still pass before this change and after the change?

@bhautikpip
Copy link
Contributor Author

Tests have passed in both the version before this change and after this change. Moreover, I have added description of the algorithm. Initially code coverage was decreased because in the older version we are using simple_wildcard_change which we do not require in this version so I have removed that function.

Copy link
Contributor

@chanchiem chanchiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine. Good job!

@bhautikpip bhautikpip merged commit dbdeab6 into aws:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants