Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR for v2.13.0 #362

Merged
merged 8 commits into from
Nov 9, 2022
Merged

Release PR for v2.13.0 #362

merged 8 commits into from
Nov 9, 2022

Conversation

atshaw43
Copy link
Contributor

@atshaw43 atshaw43 commented Nov 8, 2022

Issue #, if available:

Description of changes:
Updating change log for v2.13.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atshaw43 atshaw43 requested a review from a team as a code owner November 8, 2022 23:38
CHANGELOG.md Outdated
@@ -1,5 +1,11 @@
# Change Log

## 2.13.0 - 2022-11-08
- Oversampling Mitigation
[#PR381](https://github.com/aws/aws-xray-sdk-go/pull/381)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be formatted as [PR 381]

@jj22ee
Copy link
Contributor

jj22ee commented Nov 9, 2022

The Installing section of the README needs to be updated with the latest 2.13.0 version
https://github.com/atshaw43/aws-xray-sdk-java/tree/release-v2.13.0#Installing

CHANGELOG.md Outdated
[PR356](https://github.com/aws/aws-xray-sdk-java/pull/356)
- Add back original subsegment noOp method
[PR359](https://github.com/aws/aws-xray-sdk-java/pull/359)
- Refactoring TraceHeader Calls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change PR359 to PR 359
Also I think we can remove the "Refactoring" items from from the Changelog. Usually this is not included.

CHANGELOG.md Outdated
- Refactoring TraceHeader Calls
[PR360](https://github.com/aws/aws-xray-sdk-java/pull/360)
- Adding back depricated functions
[PR361](https://github.com/aws/aws-xray-sdk-java/pull/361)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 360 and PR 361 descriptions are swapped

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #362 (3082d4d) into master (93a5877) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #362   +/-   ##
=========================================
  Coverage     58.41%   58.41%           
  Complexity     1229     1229           
=========================================
  Files           133      133           
  Lines          5011     5011           
  Branches        589      589           
=========================================
  Hits           2927     2927           
  Misses         1814     1814           
  Partials        270      270           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atshaw43 atshaw43 merged commit 3591822 into aws:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants