Add Otel Java links to readme. Update CI badge. #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=========================================
Coverage 58.96% 58.96%
Complexity 1207 1207
=========================================
Files 131 131
Lines 5064 5064
Branches 592 592
=========================================
Hits 2986 2986
Misses 1805 1805
Partials 273 273 Continue to review full report at Codecov.
|
srprash
changed the title
NathanielRN
suggested changes
Jun 28, 2022
Co-authored-by: Nathaniel Ruiz Nowell <[email protected]>
NathanielRN
approved these changes
Jun 29, 2022
NathanielRN
reviewed
Jun 29, 2022
|
|
||
| ### :mega: OpenTelemetry Java with AWS X-Ray | ||
|
|
||
| AWS X-Ray recommends using AWS Distro for OpenTelemetry (ADOT) to instrument your application due to its wider range of features and instrumentations. See [Working with Java](https://docs.aws.amazon.com/xray/latest/devguide/xray-java.html) for more help with choosing between ADOT and X-Ray SDK. |
There was a problem hiding this comment.
I think it’s useful to add this? I find that customers often think they need both when they only need one.
Suggested change
| AWS X-Ray recommends using AWS Distro for OpenTelemetry (ADOT) to instrument your application due to its wider range of features and instrumentations. See [Working with Java](https://docs.aws.amazon.com/xray/latest/devguide/xray-java.html) for more help with choosing between ADOT and X-Ray SDK. | |
| AWS X-Ray recommends using AWS Distro for OpenTelemetry (ADOT) to instrument your application **instead of this X-Ray SDK** due to its wider range of features and instrumentations. See the [AWS X-Ray docs on Working with Java](https://docs.aws.amazon.com/xray/latest/devguide/xray-java.html) for more help with choosing between ADOT and X-Ray SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.