[aws-xray-recorder-sdk-apache-http] Don't return a null target to avoid possible NPE #338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The Apache HTTP instrumentation is prone to throwing a
NullPointerException
by returning anull
from thedetermineTarget
method. Since a user is not expected to handle NPE, it will break the application.Description of changes:
The method doesn't need to check for URL absoluteness and bail out early if it is not. The
URIUtils.extractHost(requestUri)
method does this check implicitly and we handle it'snull
return value by throwing aClientProtocolException
which a user will handle in their code.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.