Fix Sampling rules not being deleted #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangzlei
reviewed
Dec 4, 2020
| invalidate = putCustomRule(rules, i); | ||
| } | ||
| } | ||
| // Check if any rule was removed | ||
| if (!invalidate) { |
There was a problem hiding this comment.
What would happen if inputs has more than one items but the last item gets true?
There was a problem hiding this comment.
I don't understand your question.
If we receive a set with a new rule invalidate will be true and the whole set will be rebuilt so we don't need to do anything, otherwise, we check if there is a rule that is no longer present and if that's the case these changes trigger a rebuild to remove it and reconstruct the rule priorities.
wangzlei
approved these changes
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#239
Description of changes:
Review if any of the rules present in the manifest is not present in the payload to rebuild the manifest (I am not sure if removing just that rule is enough or we need to rebuild so I opted for rebuilding).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.