made SqlSubsegments handle exceptions internally #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Aug 4, 2020
aws-xray-recorder-sdk-sql/src/main/java/com/amazonaws/xray/sql/SqlSubsegments.java
Show resolved
Hide resolved
aws-xray-recorder-sdk-sql/src/test/java/com/amazonaws/xray/sql/SqlSubsegmentsTest.java
Outdated
Show resolved
Hide resolved
aws-xray-recorder-sdk-sql/src/main/java/com/amazonaws/xray/sql/SqlSubsegments.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Follow up to #186 after actually using the change, I realized that there could be some weird inconsistent state behavior the way I implemented it. An unchecked
SQLExceptioncould be thrown both before and after the subsegment was begun, so it was not a guarantee that calling the method would always create a subsegment. This was a recipe for bad behavior/segment leaks.Now, we catch all the SQL Exceptions, log useful messages, and make absolutely sure some sort of subsegment is began since that is the expected behavior.
Also exposed some of the SQL subsegment fields, since they are the publicly documented whitelisted values (e.g. won't be changing often).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.