Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing 2.6.0 #165

Merged
merged 4 commits into from
Jun 15, 2020
Merged

Releasing 2.6.0 #165

merged 4 commits into from
Jun 15, 2020

Conversation

bhautikpip
Copy link
Contributor

Issue #, if available:

Description of changes:

This PR introduces release commit which includes changes in changelog, version updates in pom.xml and benchmark README changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one note that we can probably trim down the changelog

CHANGELOG.md Outdated
[PR 150](https://github.com/aws/aws-xray-sdk-java/pull/150)
- Modified exception handling in UDPEmitter
[PR 151](https://github.com/aws/aws-xray-sdk-java/issues/151)
- Added gradle build configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave out build tooling notes from the ChangeLog they aren't really relevant to users of the library. So everything about Gradle and the various plugins and JMH version.

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go :)

@bhautikpip bhautikpip merged commit a6883a4 into aws:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants