Add xray.AWSSession to install handlers on session #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logan
force-pushed
the
aws-session
branch
4 times, most recently
from
4c1130b to
2f04984
Compare
logan
force-pushed
the
aws-session
branch
3 times, most recently
from
0b43af7 to
0c0e329
Compare
logan
force-pushed
the
aws-session
branch
2 times, most recently
from
85ad8d0 to
68c6f24
Compare
|
Hey @logan , sorry for the delay. I will review it recently. |
luluzhao
suggested changes
May 7, 2019
|
Hey Logan, we'd be happy to merge this in with a few edits. Or, we can pick it up. Thanks! |
An application has to call xray.AWS for each AWS client it constructs. This creates opportunities for blind spots if someone forgets to configure a new client. The xray.AWSSession installs the same handlers at the Session level. Clients inherit handlers from the session they're created with. As long as the application systematically reuses the same session to create clients, it only needs to install X-Ray handlers once.
|
I've added tests for the two new functions, plus the existing Travis doesn't seem to be enqueueing the test runs for this PR. but tests pass locally for me in go 1.12. |
|
@logan Thank you so much for your contribution. Merged it. |
luluzhao
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An application has to call xray.AWS for each AWS client it constructs.
This creates opportunities for blind spots if someone forgets to
configure a new client.
The xray.AWSSession installs the same handlers at the Session level.
Clients inherit handlers from the session they're created with. As long
as the application systematically reuses the same session to create
clients, it only needs to install X-Ray handlers once.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.