-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lints #117
Lints #117
Conversation
"testing" | ||
|
||
"github.com/stretchr/testify/assert" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes come from https://godoc.org/golang.org/x/tools/cmd/goimports
I think there's a bug in the code for SQL causing this test to fail.
The error return is ignored, which is resetting u to |
@cep21 you are right. We should catch the error. |
@cep21 , I am wondering why we close this PR? |
Oh that was a mistake. I deleted the branch on my end and I think github closed the PR :/ . I reopened the PR |
Fix a few lints that are somewhat easier to think about.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.