add dependency groups in nuspec for netframework462 and net6 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srprash , @NathanielRN - Thanks for catching and adding. Does this mean we get a release soon? |
|
@jon-armen We are working on a release. Please stay tuned! 🙂 |
srprash
added a commit
to srprash/aws-xray-sdk-dotnet
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The support for .NetFramework 4.6.2 and .Net 6.0 were added to the SDK in the following PRs:
#248
#242
But we missed out on adding these frameworks in the AWSXRayRecorder.nuspec which is used to create the bundle package.
Description of changes:
Adding a dependency group each for target frameworks ".NetFramework4.6.2" and "net6.0". Unfortunately, the nuget spec doesn't provide a way to group target frameworks for common set of dependencies. This results in quite a bit of redundancy in the file.
I tested creating the
AWSXRayRecoder.nupkgby running the following command and validated the package using the nuget explorer.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.