Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .netappcore version for smoke tests #228

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Update .netappcore version for smoke tests #228

merged 4 commits into from
Feb 21, 2022

Conversation

bhautikpip
Copy link
Contributor

@bhautikpip bhautikpip commented Feb 21, 2022 •
edited
Loading

Issue #, if available:
Today, Github actions have started throwing this error in continuous-monitoring workflow. I could not find any official docs on weather Github actions has stopped supporting on .netappcore2.0 but I think updating to .netappcore3.1 should fix the issue.

Testhost process exited with error: It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '2.0.0' (x64) was not found.
  - The following frameworks were found:
      3.1.4 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
      3.1.6 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
      3.1.[20](https://github.com/aws/aws-xray-sdk-dotnet/runs/5279266653?check_suite_focus=true#step:6:20) at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
      3.1.[22](https://github.com/aws/aws-xray-sdk-dotnet/runs/5279266653?check_suite_focus=true#step:6:22) at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
      5.0.4 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
      5.0.9 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
      5.0.14 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
      6.0.2 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
You can resolve the problem by installing the specified framework and/or SDK.
The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=2.0.0&arch=x64&rid=ubuntu.20.04-x64

Description of changes:
Update .netcoreapp to 3.1 version to fix monitoring workflow.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bhautikpip bhautikpip requested a review from a team as a code owner February 21, 2022 18:09
@bhautikpip bhautikpip changed the title Update continuous-monitoring.yml Update .netappcore version Feb 21, 2022
@srprash srprash changed the title Update .netappcore version Update .netappcore version for smoke tests Feb 21, 2022
@srprash srprash merged commit 193d70d into master Feb 21, 2022
srprash added a commit that referenced this pull request Mar 21, 2022
@jon-armen @srprash
@lupengamzn @sdolier @bhautikpip @dependabot @willarmiros @martincostello @samunro
3.x merge from master (#236)
88c1227 
* Create stale.yml (#136)

* Release commit for v2.9.0 (#137)

* Added 2 seconds timeout for EC2 metadata requests (#138)

* Update NOTICE so it only has third party licenses and no proprietary notice (#139)

* Fixing link to EFCore usage section (#143)

* Added EF Core installation instruction step (#145)

* Fixing race condition for initializing and running timer in RulePoller (#154)

* Bump AWSSDK.Core dependency version (#155)

* Bump AWSSDK.Core dependency version

* Bumped AWSSDK.Core version as range.

* Removed redundant dependency

* Applied HttpClient to get sampling info (#159)

* Applied HttpWebRequest to get sampling info and removed dependency on AWSSDK.XRay

* Fixed lock issue and switched to HttpClient

* Added and modified documentations.

* Added documentations.

* Set ExpectContinue header as false by default

* Adding limitation for EFCore with multiple DbCommandInterceptor (#164)

* Adding limitation for EFCore with multiple DbCommandInterceptor

* Adding doc ref for AsyncLocal

* Updated xraycontext to use a concurrent dictionary (#157)

To avoid concurrent thread access to the dictionary causing an exception

* Enable tracing S3 id pairs and fix SNS naming issue. (#168)

* Enable tracing S3 id pairs and fix SNS naming issue.

* Changed AWSSDK.Core version

* Changed parameter names and updated comments.

* Set parameters as default

* Fixed appvoyer building configuration issue. (#173)

* Add tracing support for EntityFramework 6 (.NET Framework) (#171)

* Added support for EntityFramework 6 for .NET framework.

* Added release workflow (#179)

* Added release workflow

* Added space line

* Update configuration

* Switching out AppVeyor for GH workflow (#181)

* Switching out AppVeyor for GH workflow

* Running workflow on linux as well. building wth release config

* Revert "Switching out AppVeyor for GH workflow (#181)" (#185)

This reverts commit 34134f0.

* Added public key token (#186)

* Release commit for v2.10.0 (#187)

* Updated API Doc (#188)

* Add smoke test of distribution channel (#189)

* Add smoke test of distribution channel

* Updated AWSXRayRecorder.sln

* Points to the latest version

* Publish metric on distribution availability (#190)

* Run test on ubuntu (#191)

* Bump System.Net.Http from 4.3.3 to 4.3.4 in /sdk/src/Core (#193)

Bumps System.Net.Http from 4.3.3 to 4.3.4.

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Release commit for v2.10.1 (#194)

* Update continuous-monitoring.yml

* Increase continuous monitoring to 10 minutes

* Add netcoreapp3.1 target framework

Add a target framework moniker for .NET Core 3.1.

* Create CODEOWNERS

* Update appveyor.yml (#226)

* Update appveyor.yml

* Update appveyor.yml

* Update .netappcore version for smoke tests (#228)

* Update continuous-monitoring.yml

* Update netcoreapp version in .csproj file

* Update continuous-monitoring.yml

* Update AWSXRayRecorder.SmokeTests.csproj

* Use GitHub workflow for CI on PRs and master builds (#231)

* Update continuous-monitoring.yml

* Add Source Link support for enhanced debugging experience (#229)

* Add Source Link support for enhanced debugging experience

* NetFramework does not support embedded pdb

Co-authored-by: Jon Armen <[email protected]>

* Finding the same exception in different subsegments should reuse the same cause id (#210)

Co-authored-by: Jon Armen <[email protected]>

* Removed blocking call which was producing deadlocks from EC2Plugin. (#234)

* Adding 3.x for continous build

Co-authored-by: srprash <[email protected]>
Co-authored-by: Anuraag Agrawal <[email protected]>
Co-authored-by: Lu Peng <[email protected]>
Co-authored-by: Stephen D'Olier <[email protected]>
Co-authored-by: Bhautik Pipaliya <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: William Armiros <[email protected]>
Co-authored-by: martincostello <[email protected]>
Co-authored-by: Jon Armen <[email protected]>
Co-authored-by: Scott Munro <[email protected]>
jon-armen added a commit to jon-armen/aws-xray-sdk-dotnet that referenced this pull request Apr 15, 2022
@jon-armen @srprash
@lupengamzn @sdolier @bhautikpip @dependabot @willarmiros @martincostello @samunro
3.x merge from master (aws#236)
c94733d 
* Create stale.yml (aws#136)

* Release commit for v2.9.0 (aws#137)

* Added 2 seconds timeout for EC2 metadata requests (aws#138)

* Update NOTICE so it only has third party licenses and no proprietary notice (aws#139)

* Fixing link to EFCore usage section (aws#143)

* Added EF Core installation instruction step (aws#145)

* Fixing race condition for initializing and running timer in RulePoller (aws#154)

* Bump AWSSDK.Core dependency version (aws#155)

* Bump AWSSDK.Core dependency version

* Bumped AWSSDK.Core version as range.

* Removed redundant dependency

* Applied HttpClient to get sampling info (aws#159)

* Applied HttpWebRequest to get sampling info and removed dependency on AWSSDK.XRay

* Fixed lock issue and switched to HttpClient

* Added and modified documentations.

* Added documentations.

* Set ExpectContinue header as false by default

* Adding limitation for EFCore with multiple DbCommandInterceptor (aws#164)

* Adding limitation for EFCore with multiple DbCommandInterceptor

* Adding doc ref for AsyncLocal

* Updated xraycontext to use a concurrent dictionary (aws#157)

To avoid concurrent thread access to the dictionary causing an exception

* Enable tracing S3 id pairs and fix SNS naming issue. (aws#168)

* Enable tracing S3 id pairs and fix SNS naming issue.

* Changed AWSSDK.Core version

* Changed parameter names and updated comments.

* Set parameters as default

* Fixed appvoyer building configuration issue. (aws#173)

* Add tracing support for EntityFramework 6 (.NET Framework) (aws#171)

* Added support for EntityFramework 6 for .NET framework.

* Added release workflow (aws#179)

* Added release workflow

* Added space line

* Update configuration

* Switching out AppVeyor for GH workflow (aws#181)

* Switching out AppVeyor for GH workflow

* Running workflow on linux as well. building wth release config

* Revert "Switching out AppVeyor for GH workflow (aws#181)" (aws#185)

This reverts commit 34134f0.

* Added public key token (aws#186)

* Release commit for v2.10.0 (aws#187)

* Updated API Doc (aws#188)

* Add smoke test of distribution channel (aws#189)

* Add smoke test of distribution channel

* Updated AWSXRayRecorder.sln

* Points to the latest version

* Publish metric on distribution availability (aws#190)

* Run test on ubuntu (aws#191)

* Bump System.Net.Http from 4.3.3 to 4.3.4 in /sdk/src/Core (aws#193)

Bumps System.Net.Http from 4.3.3 to 4.3.4.

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Release commit for v2.10.1 (aws#194)

* Update continuous-monitoring.yml

* Increase continuous monitoring to 10 minutes

* Add netcoreapp3.1 target framework

Add a target framework moniker for .NET Core 3.1.

* Create CODEOWNERS

* Update appveyor.yml (aws#226)

* Update appveyor.yml

* Update appveyor.yml

* Update .netappcore version for smoke tests (aws#228)

* Update continuous-monitoring.yml

* Update netcoreapp version in .csproj file

* Update continuous-monitoring.yml

* Update AWSXRayRecorder.SmokeTests.csproj

* Use GitHub workflow for CI on PRs and master builds (aws#231)

* Update continuous-monitoring.yml

* Add Source Link support for enhanced debugging experience (aws#229)

* Add Source Link support for enhanced debugging experience

* NetFramework does not support embedded pdb

Co-authored-by: Jon Armen <[email protected]>

* Finding the same exception in different subsegments should reuse the same cause id (aws#210)

Co-authored-by: Jon Armen <[email protected]>

* Removed blocking call which was producing deadlocks from EC2Plugin. (aws#234)

* Adding 3.x for continous build

Co-authored-by: srprash <[email protected]>
Co-authored-by: Anuraag Agrawal <[email protected]>
Co-authored-by: Lu Peng <[email protected]>
Co-authored-by: Stephen D'Olier <[email protected]>
Co-authored-by: Bhautik Pipaliya <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: William Armiros <[email protected]>
Co-authored-by: martincostello <[email protected]>
Co-authored-by: Jon Armen <[email protected]>
Co-authored-by: Scott Munro <[email protected]>
jon-armen added a commit to jon-armen/aws-xray-sdk-dotnet that referenced this pull request Apr 15, 2022
@jon-armen @srprash
@lupengamzn @sdolier @bhautikpip @dependabot @willarmiros @martincostello @samunro
3.x merge from master (aws#236)
6cd55ac 
* Create stale.yml (aws#136)

* Release commit for v2.9.0 (aws#137)

* Added 2 seconds timeout for EC2 metadata requests (aws#138)

* Update NOTICE so it only has third party licenses and no proprietary notice (aws#139)

* Fixing link to EFCore usage section (aws#143)

* Added EF Core installation instruction step (aws#145)

* Fixing race condition for initializing and running timer in RulePoller (aws#154)

* Bump AWSSDK.Core dependency version (aws#155)

* Bump AWSSDK.Core dependency version

* Bumped AWSSDK.Core version as range.

* Removed redundant dependency

* Applied HttpClient to get sampling info (aws#159)

* Applied HttpWebRequest to get sampling info and removed dependency on AWSSDK.XRay

* Fixed lock issue and switched to HttpClient

* Added and modified documentations.

* Added documentations.

* Set ExpectContinue header as false by default

* Adding limitation for EFCore with multiple DbCommandInterceptor (aws#164)

* Adding limitation for EFCore with multiple DbCommandInterceptor

* Adding doc ref for AsyncLocal

* Updated xraycontext to use a concurrent dictionary (aws#157)

To avoid concurrent thread access to the dictionary causing an exception

* Enable tracing S3 id pairs and fix SNS naming issue. (aws#168)

* Enable tracing S3 id pairs and fix SNS naming issue.

* Changed AWSSDK.Core version

* Changed parameter names and updated comments.

* Set parameters as default

* Fixed appvoyer building configuration issue. (aws#173)

* Add tracing support for EntityFramework 6 (.NET Framework) (aws#171)

* Added support for EntityFramework 6 for .NET framework.

* Added release workflow (aws#179)

* Added release workflow

* Added space line

* Update configuration

* Switching out AppVeyor for GH workflow (aws#181)

* Switching out AppVeyor for GH workflow

* Running workflow on linux as well. building wth release config

* Revert "Switching out AppVeyor for GH workflow (aws#181)" (aws#185)

This reverts commit 34134f0.

* Added public key token (aws#186)

* Release commit for v2.10.0 (aws#187)

* Updated API Doc (aws#188)

* Add smoke test of distribution channel (aws#189)

* Add smoke test of distribution channel

* Updated AWSXRayRecorder.sln

* Points to the latest version

* Publish metric on distribution availability (aws#190)

* Run test on ubuntu (aws#191)

* Bump System.Net.Http from 4.3.3 to 4.3.4 in /sdk/src/Core (aws#193)

Bumps System.Net.Http from 4.3.3 to 4.3.4.

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Release commit for v2.10.1 (aws#194)

* Update continuous-monitoring.yml

* Increase continuous monitoring to 10 minutes

* Add netcoreapp3.1 target framework

Add a target framework moniker for .NET Core 3.1.

* Create CODEOWNERS

* Update appveyor.yml (aws#226)

* Update appveyor.yml

* Update appveyor.yml

* Update .netappcore version for smoke tests (aws#228)

* Update continuous-monitoring.yml

* Update netcoreapp version in .csproj file

* Update continuous-monitoring.yml

* Update AWSXRayRecorder.SmokeTests.csproj

* Use GitHub workflow for CI on PRs and master builds (aws#231)

* Update continuous-monitoring.yml

* Add Source Link support for enhanced debugging experience (aws#229)

* Add Source Link support for enhanced debugging experience

* NetFramework does not support embedded pdb

Co-authored-by: Jon Armen <[email protected]>

* Finding the same exception in different subsegments should reuse the same cause id (aws#210)

Co-authored-by: Jon Armen <[email protected]>

* Removed blocking call which was producing deadlocks from EC2Plugin. (aws#234)

* Adding 3.x for continous build

Co-authored-by: srprash <[email protected]>
Co-authored-by: Anuraag Agrawal <[email protected]>
Co-authored-by: Lu Peng <[email protected]>
Co-authored-by: Stephen D'Olier <[email protected]>
Co-authored-by: Bhautik Pipaliya <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: William Armiros <[email protected]>
Co-authored-by: martincostello <[email protected]>
Co-authored-by: Jon Armen <[email protected]>
Co-authored-by: Scott Munro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srprash srprash srprash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhautikpip @srprash