Remove custom backoff logic for sending segments #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atshaw43
reviewed
Jan 26, 2023
pkg/processor/batchprocessor.go
Outdated
| @@ -68,7 +61,7 @@ func (s *segmentsBatch) send(batch []*string) { | |||
| } | |||
|
|
|||
| func (s *segmentsBatch) poll() { | |||
| failedAttempt := 0 | |||
| //failedAttempt := 0 | |||
There was a problem hiding this comment.
Let's delete this instead of commenting it out.
There was a problem hiding this comment.
Thanks for catching that!
| @@ -112,157 +110,6 @@ func TestPollSendSuccess(t *testing.T) { | |||
| assert.True(t, strings.Contains(log.Logs[1], doneMsg)) | |||
| } | |||
|
|
|||
| func TestPollSendFailedOnceMoreThanMin(t *testing.T) { | |||
There was a problem hiding this comment.
We removed quite a few tests because of the new functionality.
Can we add some back in that test the new functionality?
There was a problem hiding this comment.
With the removal of custom backoff logic, we automatically fall to the AWS SDK retry behavior which is not a new functionality in our code base. Are you suggesting we add a unit test for the AWS SDK retry functionality? IMO it won't be appropriate because if their retry behavior changes, it will break our tests.
atshaw43
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The current behavior of X-Ray Daemon when it fails to send segments is to block the send which can lead to build up of segments in memory in high traffic situations. There is a backoff logic in addition to the one on the AWS SDK client. This additional backoff logic can make it difficult to reason about the retry policies of the X-Ray Daemon.
Description of changes:
Removed custom code for backoff logic and related unit tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.