Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry(amazonq): add feedback functionality with thumbs up/down #6560

Merged
merged 6 commits into from
Feb 12, 2025
Merged

telemetry(amazonq): add feedback functionality with thumbs up/down #6560

merged 6 commits into from
Feb 12, 2025
+94 −8

Conversation

chungjac
Copy link
Contributor

@chungjac chungjac commented Feb 11, 2025 •
edited
Loading

Problem

  • /test and /review are missing thumbs up/down telemetry
  • /test is missing feedback functionality
Screenshot 2025-02-11 at 1 58 42 PM Screenshot 2025-02-11 at 1 58 48 PM

Solution

  • send telemetry event for thumps up/down for /test and /review
  • send user feedback for /test which routes to SIM folder
  • No tests were added as this is UX change
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested review from a team as code owners February 11, 2025 21:56
@chungjac chungjac force-pushed the feedback-functionality branch from 8f7dae3 to 505ad34 Compare February 11, 2025 21:56
@github-actions GitHub Actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

laileni-aws
laileni-aws approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chungjac chungjac enabled auto-merge (squash) February 11, 2025 23:51
@chungjac chungjac merged commit 20975a6 into aws:master Feb 12, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laileni-aws laileni-aws laileni-aws approved these changes

@dogusata dogusata dogusata approved these changes

@ashishrp-aws ashishrp-aws ashishrp-aws approved these changes

@hayemaxi hayemaxi hayemaxi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chungjac @dogusata @laileni-aws @ashishrp-aws @hayemaxi