fix(tests): Increase git buffer size so cfn/sam schema can be downloaded #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aded Currently the integration tests in #3042 are failing because the SAM schema fails to download with ```stdout maxBuffer length exceeded``` Increase buffer size
nkomonen-amazon
approved these changes
Jan 4, 2023
JadenSimon
approved these changes
Jan 4, 2023
| @@ -369,7 +369,7 @@ export class GitExtension { | |||
|
|
|||
| return execFileAsync(api.git.path, ['cat-file', type, hash], { | |||
| cwd: tmpDir, | |||
| maxBuffer: 1024 * 1024 * 5, | |||
| maxBuffer: 1024 * 1024 * 6, | |||
There was a problem hiding this comment.
Let's just set it to 50MB:
Suggested change
| maxBuffer: 1024 * 1024 * 6, | |
| maxBuffer: 1024 * 1024 * 50, |
This thread mentions dynamic sizing a potential solution. Not sure if Node dynamically sizes the buffer already or if the buffer is allocated based off maxBuffer. If the former then Infinity could work although it would make it easier to run out of memory on the heap, crashing V8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the integration tests in #3042 are failing because the SAM schema fails to download with
stdout maxBuffer length exceededSolution
Increase git buffer size
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.