Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds event listener for notifying UI that AB feature configurations have been resolved #5308

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

spfink
Copy link
Contributor

@spfink spfink commented Jan 28, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Adds a new event listener object and handler to allow the application to notify the UI when feature configs have been resolved. For now, this is just the highlight command as that is all the UI needs. In the future we can use this class to plumb through additional features.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@spfink spfink requested review from a team as code owners January 28, 2025 21:58
ApplicationManager.getApplication().messageBus.connect(this).subscribe(
CodeWhispererFeatureConfigListener.TOPIC,
object : CodeWhispererFeatureConfigListener {
override fun refreshUi() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offline agreed to rename

@spfink spfink force-pushed the finks/feature-listener branch 3 times, most recently from ce7f985 to 6026c76 Compare January 29, 2025 00:51
@spfink spfink closed this Jan 29, 2025
@spfink spfink force-pushed the finks/feature-listener branch from 5d9b2b7 to 0cd4bca Compare January 29, 2025 18:15
@spfink spfink reopened this Jan 29, 2025
@spfink spfink force-pushed the finks/feature-listener branch from 3e65fc8 to 8bee84c Compare January 29, 2025 18:16
@rli rli merged commit a545699 into aws:main Jan 31, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants