Fixed lambda event json file parser and validation #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodnyab
reviewed
Dec 29, 2022
| @@ -48,16 +47,10 @@ object PartitionParser { | |||
| mapper.readValue(inputStream, Partitions::class.java) | |||
| } | |||
| } | |||
| object EndpointsJsonValidator : RemoteResolveParser { | |||
There was a problem hiding this comment.
Should this be deleted? Would this object be required to validate the endpoints file?
There was a problem hiding this comment.
Got it, adding back
manodnyab
reviewed
Jan 3, 2023
| EndpointsJsonValidatorTest::class.java.getResourceAsStream("/jsonSampleFailure.json").use { | ||
| assertFalse(EndpointsJsonValidator.canBeParsed(it)) | ||
| TestCase.assertFalse(EndpointsJsonValidator.canBeParsed(it)) |
There was a problem hiding this comment.
Could probably use Assertions.assertThat while asserting all test cases
manodnyab
approved these changes
Jan 4, 2023
| import software.aws.toolkits.core.lambda.LambdaSampleEventJsonValidator | ||
| class LambdaSampleEventJsonValidatorTest { | ||
| @Test | ||
| fun isJsonParse() { |
There was a problem hiding this comment.
nit: rename test to Lambda sample event file can be parsed successfully?
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Fixed lambda event json file parser and validation
Motivation and Context
Related Issue(s)
#3359
Screenshots (if appropriate)
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.