Fix Enter action will add incorrect number of newlines when triggered inside braces #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inside braces 1. When enter action is triggered inside braces, an EnterBetweenBracesFinalHandler will be invoked which is an EnterHandlerDelegate, this delegate will call originalHandler.execute() to add an extra newline to correctly put the closing brace in another new line. Inside CodeWhispererEnterHandler we need to call originalHandler.execute() instead of super.executeWriteAction() to avoid adding another(3rd) newline character in the document. 2. Since the originalHandler in EnterHandler is private not protected, need to make the originalHander in CodeWhispererEnterHandler a private field.
andrewyuq
changed the title
andrewyuq
changed the title
|
please include a changelog entry for this |
rli
approved these changes
Aug 19, 2022
rli
reviewed
Aug 19, 2022
.changes/next-release/bugfix-f4efde0c-8cd5-413c-af47-aaf1f38aa84d.json
Outdated
Show resolved
Hide resolved
…84d.json Co-authored-by: Richard Li <[email protected]>
Will-ShaoHua
approved these changes
Aug 19, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will be invoked which is an EnterHandlerDelegate, this delegate will call
originalHandler.execute() to add an extra newline to correctly put the closing
brace in another new line. Inside CodeWhispererEnterHandler we need to call
originalHandler.execute() instead of super.executeWriteAction() to avoid
adding another(3rd) newline character in the document.
make the originalHander in CodeWhispererEnterHandler a private field.
Types of changes
Description
Motivation and Context
Related Issue(s)
Testing
Added a test which will not pass before the fix but will pass after the fix.
Screenshots (if appropriate)
Checklist
gradlew checksucceedsLicense
I confirm that my contribution is made under the terms of the Apache 2.0 license.