Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XML parsing flattened shape from shape ref #1766

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Fix XML parsing flattened shape from shape ref #1766

merged 1 commit into from
Apr 24, 2018

Conversation

cjyclaire
Copy link
Contributor

Addressing #1764
Tested manually with api call.

@cjyclaire cjyclaire requested a review from awood45 April 24, 2018 00:00
@cjyclaire cjyclaire mentioned this pull request Apr 24, 2018
Closed
awood45
awood45 approved these changes Apr 24, 2018
View reviewed changes
Copy link
Member

@awood45 awood45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider an integration test which hits the failing API call, but looks good.

@cjyclaire cjyclaire merged commit c39d9be into master Apr 24, 2018
@cjyclaire cjyclaire deleted the fix-flattened-xml branch May 22, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awood45 awood45 awood45 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjyclaire @awood45