Support New Regions and Endpoints File #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def get_partition(region) | ||
| RULES["partitions"].find do |p| | ||
| region.match(p["regionRegex"]) | ||
| end |
There was a problem hiding this comment.
The #get_partition method could own the logic of returning 'aws' as the default partion if the region does not match the regex of any known partition. This removes the need for the nil check above.
|
Did you consider also utilizing the endpoint specific metadata for influencing the connection? For example, utilizing signaturerVersions, signing names, etc? |
trevorrowe
force-pushed
the
regions-and-endpoints
branch
from
91c9876 to
738c5c0
Compare
Work in progress migration to the new regions and endpoints file. Tests are passing, and we appear to resolve regions correctly at this time.
Mainly relevant to the "s3-external-1" endpoint, but in theory could apply for more service/region pairs in the future.
Use a valid region name for signing.
Additionally, supports switching the endpoints.json file to another path.
Fixed a number of issues revealed in testing.
trevorrowe
force-pushed
the
regions-and-endpoints
branch
from
738c5c0 to
4b4eb55
Compare
| # Aws.partitions.each do |partition| | ||
| # puts partition.name | ||
| # end | ||
| # |
There was a problem hiding this comment.
I'd love the "all everything in everywhere" example to be present, since that's a use case some have. For example:
Aws.partitions.each do |partition|
partition.regions.each do |region|
region.services.each do |service|
# Do anything you'd want to do for all services in all regions.
puts "#{service} is in #{region.name} in #{partition.name}"
end
end
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.