make credentials provider chain resolve synchronous. (#2456)

aws · Dec 26, 2018 · 9a9d7e8 · 9a9d7e8
1 parent 8db24fb
commit 9a9d7e8
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/.changes/next-release/bugfix-credentials-3d679332.json b/.changes/next-release/bugfix-credentials-3d679332.json
@@ -0,0 +1,5 @@
+{
+  "type": "bugfix",
+  "category": "credentials",
+  "description": "Make CredentialProviderChain coalesce resolvation synchronous"
+}
diff --git a/lib/credentials/credential_provider_chain.js b/lib/credentials/credential_provider_chain.js
@@ -108,9 +108,7 @@ AWS.CredentialProviderChain = AWS.util.inherit(AWS.Credentials, {
       function resolveNext(err, creds) {
         if ((!err && creds) || index === providers.length) {
           AWS.util.arrayEach(self.resolveCallbacks, function (callback) {
-            AWS.util.defer(function () {
-              callback(err, creds);
-            });
+            callback(err, creds);
           });
           self.resolveCallbacks.length = 0;
           return;

diff --git a/test/credential_provider_chain.spec.js b/test/credential_provider_chain.spec.js