-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for AWS rest-xml protocol #727
Conversation
This comment has been minimized.
This comment has been minimized.
...ain/java/software/amazon/smithy/aws/typescript/codegen/RestXmlResponseProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...ain/java/software/amazon/smithy/aws/typescript/codegen/RestXmlResponseProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...ain/java/software/amazon/smithy/aws/typescript/codegen/RestXmlResponseProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...pt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsProtocolUtils.java
Show resolved
Hide resolved
...ain/java/software/amazon/smithy/aws/typescript/codegen/RestXmlResponseProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...degen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlMemberDeserVisitor.java
Show resolved
Hide resolved
...odegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeDeserVisitor.java
Outdated
Show resolved
Hide resolved
...-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeSerVisitor.java
Outdated
Show resolved
Hide resolved
...-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeSerVisitor.java
Show resolved
Hide resolved
...-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeSerVisitor.java
Outdated
Show resolved
Hide resolved
...-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeSerVisitor.java
Show resolved
Hide resolved
...odegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeDeserVisitor.java
Outdated
Show resolved
Hide resolved
This commit adds support for the `aws.rest-xml` protocol, building on top of the `HttpBindingProtocolGenerator` for document and payload serde. Implementations of the `DocumentMember[Deser|Ser]Visitor` and the `DocumentShape[Deser|Ser]Visitor` have been created that handle Smithy's XML traits and their influence on protocol serde. A minor update has been made to the `XmlNode` to allow for nodes to be renamed, as the same structure may change XML node names when it is bound to different locations.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it! 🎉🎉
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Add support for AWS rest-xml protocol
This commit adds support for the
aws.rest-xml
protocol, buildingon top of the
HttpBindingProtocolGenerator
for document andpayload serde.
Implementations of the
DocumentMember[Deser|Ser]Visitor
and theDocumentShape[Deser|Ser]Visitor
have been created that handleSmithy's XML traits and their influence on protocol serde.
A minor update has been made to the
XmlNode
to allow for nodes tobe renamed, as the same structure may change XML node names when it
is bound to different locations.
Handles namespaces on payloads/services/structures:
Payload:
Service for document:
Structure specific:
Handles flattened and unflattened aggregate shapes:
Unflattened:
Flattened:
Handles attributes and names:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.